`elastic-agent install`: Only uninstall when Agent is installed #3415

ycombinator · 2023-09-14T11:45:27Z

What does this PR do?

This PR improves the elastic-agent install experience by only trying to uninstall the existing Elastic Agent installation if Elastic Agent is currently installed.

Why is it important?

So the progress messages shown to the user during elastic-agent install are not misleading by suggesting that the existing Elastic Agent installation is being uninstalled, even when there is no Elastic Agent currently installed.

Checklist

My code follows the style guidelines of this project
I have commented my code, particularly in hard-to-understand areas
~~I have made corresponding changes to the documentation~~
~~I have made corresponding change to the default configuration files~~
~~I have added tests that prove my fix is effective or that my feature works~~
~~I have added an entry in ./changelog/fragments using the changelog tool~~
~~I have added an integration test or an E2E test~~

How to test this PR locally

Start with a host where Elastic Agent is NOT currently installed.
Build Elastic Agent from this PR and install it.
```
 sudo ./elastic-agent install
```
Verify that the progress messages shown do NOT include a message about Elastic Agent being uninstalled.
Verify that the installation succeeds.
```
 sudo elastic-agent status
```
Try to install Elastic Agent again.
```
 sudo ./elastic-agent install
```
Verify that installation fails with a message about Elastic Agent already being installed.
Try to install Elastic Agent again, this time with the --force flag.
```
 sudo ./elastic-agent install --force
```
Verify that the progress messages shown include a message about Elastic Agent being uninstalled.
Verify that the installation succeeds.
```
 sudo elastic-agent status
```

Related issues

Resolves Misguiding information- Uninstalling current Elastic Agent is shown under CLI while installing elastic-agent. #3414

ycombinator · 2023-09-14T11:45:55Z

internal/pkg/agent/cmd/install.go

@@ -83,7 +83,7 @@ func installCmd(streams *cli.IOStreams, cmd *cobra.Command) error {

 	nonInteractive, _ := cmd.Flags().GetBool("non-interactive")
 	if nonInteractive {
-		fmt.Fprintf(streams.Out, "Installing in non-interactive mode.")
+		fmt.Fprintln(streams.Out, "Installing in non-interactive mode.")


Not strictly related to the changes in this PR.

elasticmachine · 2023-09-14T11:49:32Z

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS

Expand to view the summary

Build stats

Start Time: 2023-09-25T15:17:59.007+0000
Duration: 25 min 48 sec

Test stats 🧪

Test	Results
Failed	0
Passed	6313
Skipped	59
Total	6372

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

/test : Re-trigger the build.
/package : Generate the packages.
run integration tests : Run the Elastic Agent Integration tests.
run end-to-end tests : Generate the packages and run the E2E Tests.
run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

elasticmachine · 2023-09-14T11:51:31Z

Pinging @elastic/elastic-agent (Team:Elastic-Agent)

elasticmachine · 2023-09-14T12:15:19Z

🌐 Coverage report

Name	Metrics % (`covered/total`)	Diff
Packages	98.78% (`81/82`)	👍
Files	66.102% (`195/295`)	👍
Classes	65.693% (`360/548`)	👍
Methods	52.769% (`1134/2149`)	👍
Lines	38.18% (`12853/33664`)	👎 -0.047
Conditionals	100.0% (`0/0`)	💚

blakerouse

Looks good!

ycombinator · 2023-09-19T22:27:34Z

/test

mergify · 2023-09-21T16:31:01Z

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b install-uninstall-with-force upstream/install-uninstall-with-force
git merge upstream/main
git push upstream install-uninstall-with-force

pchila

LGTM

@ycombinator could you please solve the conflicts so we can merge this ?

elastic-sonarqube · 2023-09-25T16:51:41Z

SonarQube Quality Gate

0 Bugs
0 Vulnerabilities
0 Security Hotspots
1 Code Smell

0.0% Coverage
0.0% Duplication

* Only uninstall if --force is present * Improve help text * Add missing newline * Don't pass force * Fix more conflicts * Fixing compile error introduced while resolving conflicts (cherry picked from commit 0c43005) # Conflicts: # internal/pkg/agent/install/install.go

…gent is installed (#3472) * `elastic-agent install`: Only uninstall when Agent is installed (#3415) * Only uninstall if --force is present * Improve help text * Add missing newline * Don't pass force * Fix more conflicts * Fixing compile error introduced while resolving conflicts (cherry picked from commit 0c43005) # Conflicts: # internal/pkg/agent/install/install.go * Addressing conflicts --------- Co-authored-by: Shaunak Kashyap <[email protected]>

ycombinator added backport-skip skip-changelog labels Sep 14, 2023

ycombinator commented Sep 14, 2023

View reviewed changes

mergify bot assigned ycombinator Sep 14, 2023

ycombinator added >bug Team:Elastic-Agent Label for the Agent team labels Sep 14, 2023

ycombinator marked this pull request as ready for review September 14, 2023 11:51

ycombinator requested a review from a team as a code owner September 14, 2023 11:51

ycombinator requested review from blakerouse and pchila September 14, 2023 11:51

ycombinator force-pushed the install-uninstall-with-force branch from 4f5f10f to f8a8bf1 Compare September 14, 2023 14:28

blakerouse approved these changes Sep 19, 2023

View reviewed changes

ycombinator force-pushed the install-uninstall-with-force branch from f8a8bf1 to df1d988 Compare September 19, 2023 17:03

pchila approved these changes Sep 25, 2023

View reviewed changes

ycombinator added 4 commits September 25, 2023 07:27

Only uninstall if --force is present

ac78ee1

Improve help text

1980382

Add missing newline

315b567

Don't pass force

090831e

ycombinator force-pushed the install-uninstall-with-force branch from df1d988 to 090831e Compare September 25, 2023 14:29

ycombinator added 2 commits September 25, 2023 08:13

Fix more conflicts

2da2fed

Fixing compile error introduced while resolving conflicts

cf5deb0

ycombinator enabled auto-merge (squash) September 25, 2023 18:05

ycombinator added backport-v8.10.0 Automated backport with mergify and removed backport-skip labels Sep 25, 2023

ycombinator merged commit 0c43005 into elastic:main Sep 25, 2023

mergify bot mentioned this pull request Sep 25, 2023

[8.10](backport #3415) elastic-agent install: Only uninstall when Agent is installed #3472

Merged

fearful-symmetry mentioned this pull request Oct 27, 2023

Windows: install on system with previous uninstalled agent fails with missing field accessing 'outputs' #3672

Closed

ycombinator deleted the install-uninstall-with-force branch November 27, 2023 20:05

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

`elastic-agent install`: Only uninstall when Agent is installed #3415

`elastic-agent install`: Only uninstall when Agent is installed #3415

ycombinator commented Sep 14, 2023 •

edited

Loading

ycombinator Sep 14, 2023

elasticmachine commented Sep 14, 2023 •

edited

Loading

Build stats

Test stats 🧪

elasticmachine commented Sep 14, 2023

elasticmachine commented Sep 14, 2023 •

edited

Loading

blakerouse left a comment

ycombinator commented Sep 19, 2023

mergify bot commented Sep 21, 2023

pchila left a comment

elastic-sonarqube bot commented Sep 25, 2023

elastic-agent install: Only uninstall when Agent is installed #3415

elastic-agent install: Only uninstall when Agent is installed #3415

Conversation

ycombinator commented Sep 14, 2023 • edited Loading

What does this PR do?

Why is it important?

Checklist

How to test this PR locally

Related issues

ycombinator Sep 14, 2023

Choose a reason for hiding this comment

elasticmachine commented Sep 14, 2023 • edited Loading

💚 Build Succeeded

Build stats

Test stats 🧪

💚 Flaky test report

🤖 GitHub comments

elasticmachine commented Sep 14, 2023

elasticmachine commented Sep 14, 2023 • edited Loading

🌐 Coverage report

blakerouse left a comment

Choose a reason for hiding this comment

ycombinator commented Sep 19, 2023

mergify bot commented Sep 21, 2023

pchila left a comment

Choose a reason for hiding this comment

elastic-sonarqube bot commented Sep 25, 2023

`elastic-agent install`: Only uninstall when Agent is installed #3415

`elastic-agent install`: Only uninstall when Agent is installed #3415

ycombinator commented Sep 14, 2023 •

edited

Loading

elasticmachine commented Sep 14, 2023 •

edited

Loading

elasticmachine commented Sep 14, 2023 •

edited

Loading